Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(core): parallelise core test suite #2622

Merged
merged 15 commits into from
Apr 4, 2024

Conversation

bernardobridge
Copy link
Contributor

@bernardobridge bernardobridge commented Apr 4, 2024

Description

Lengthy PR because there was a lot of reshuffling/refactoring that was needed for some of this. Reviewing commit by commit might be easier.

Reduces test runtime for core from 9 minutes to <2 minutes locally. Overall it reduces test runtime in CI to about 4-5 minutes. A few things:

  • Some follow up PR's will be added to just refactor some of the naming conventions to grep easier, but didn't want to make this PR too messy. Also there are a couple of things I want to clean up
  • A couple of tests were quarantine'd right now, as I need to review why they're not working separately
  • Some further optimisation is still possible, I'll explore it separately
  • Funny enough, now the longest runtime thing is our examples - using-data-from-csv is an unnecessarily long test (8 mins), maybe we should just reduce that too

@bernardobridge bernardobridge marked this pull request as ready for review April 4, 2024 10:51
@bernardobridge bernardobridge requested a review from a team April 4, 2024 10:52
@bernardobridge bernardobridge merged commit db92535 into main Apr 4, 2024
14 checks passed
@bernardobridge bernardobridge deleted the bernardobridge/art-1714-parallelise-core-suite branch April 4, 2024 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant