Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ArtipieServer.java:83-89: Extract class for building... #470

Closed
0pdd opened this issue Aug 20, 2020 · 1 comment · Fixed by #928
Closed

ArtipieServer.java:83-89: Extract class for building... #470

0pdd opened this issue Aug 20, 2020 · 1 comment · Fixed by #928
Assignees
@olenagerasimova
Labels
0crat/new stale

Comments

@0pdd
Copy link

0pdd commented Aug 20, 2020

The puzzle 449-3e9e55ee from #449 has to be resolved:

artipie/src/test/java/com/artipie/ArtipieServer.java

Lines 83 to 89 in 5966489

* @todo #449:30min Extract class for building settings in YAML format.
* Building of settings YAML for usage in tests occurs more the once.
* It is used to build setting in `ArtipieServer`
* and in `YamlSettingsTest` to create settings examples in unit tests.
* Some examples in `YamlSettingsTest` are just string constants.
* It would be nice to extract a class for building settings in YAML format
* for usage in all these places.

The puzzle was created by Oleg Mozzhechkov on 20-Aug-20.

Estimate: 30 minutes, role: DEV.

If you have any technical questions, don't ask me, submit new tickets instead. The task will be "done" when the problem is fixed and the text of the puzzle is removed from the source code. Here is more about PDD and about me.
0pdd referenced this issue Aug 20, 2020
@olegmoz
Merge pull request #468 from olegmoz/449-single-repo-server
5966489 
#449 - Added ArtipieServer class
@0pdd 0pdd mentioned this issue Aug 20, 2020
Closed
@github-actions
Copy link

github-actions bot commented Aug 4, 2021

Issue is stale, CC: @g4s8

@github-actions github-actions bot added the stale label Aug 4, 2021
@olenagerasimova olenagerasimova mentioned this issue Aug 19, 2021
Merged
@g4s8 g4s8 closed this as completed in #928 Aug 19, 2021
g4s8 pushed a commit that referenced this issue Aug 19, 2021
@olenagerasimova
doc: removed not actual @todo (#928)
eadc435 
I do not think refactoring from this todo is actually required: as there are basically only two places in test code where artipie.yaml is created - `ArtipieServer` and test for settings `YamlSettingsTest`. `YamlSettingsTest` has a lot of different variants of artipie.yaml (to test that in all cases settings are read correctly) and for test it's ok (and even better in my opinion) to have all these variants as string stabs.

Close: #470
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@olenagerasimova olenagerasimova

Labels
0crat/new stale
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Removed not actual @todo olenagerasimova/artipie
3 participants
@olenagerasimova @0crat @0pdd