Lazy getting of settings layout from Artipie server #113
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andpopov
changed the title
|
@olenagerasimova Please review |
olenagerasimova
requested changes
Nov 8, 2022
There was a problem hiding this comment.
@andpopov I'm not sure I see the point in starting front without Artipie, we could just print the warning about failing to connect to the main server and shut down... Please, discuss this case with Denis, what does he think?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of #101
Currently if Artipie server is down the front cannot start because it requests layout setting during startup.
Front should start without pre-run Artipie server