Artipie http3 test #13
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dgarus
reviewed
Nov 30, 2023
| MatcherAssert.assertThat("Maven install is not successful", exec.getExitCode() == 0); | ||
| MatcherAssert.assertThat( | ||
| res, | ||
| Matchers.stringContainsInOrder( |
There was a problem hiding this comment.
How can it prove that the packages were gotten by HTTP 3?
There was a problem hiding this comment.
a) https://artipie:8091/my-maven-proxy - is a path to artipie http3 repository
b) is such configuration maven client can perform request over http3 only (it fails trying to get dependency from central over http 1)
So there are only 2 possibilities in current configuration: either build is success and deps were obtained via http3 or it fails
|
@dgarus I've corrected logs and assertion |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added integration test for plugin and artipie, also:
InputStream(viaInputStreamResponseListener) instead of byte array after gettingbuffering capacity exceedederror for some heavy jar