feat: optimization of adapter code #551
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #551 +/- ##
============================================
+ Coverage 87.71% 87.73% +0.02%
+ Complexity 469 466 -3
============================================
Files 52 52
Lines 1889 1884 -5
Branches 167 163 -4
============================================
- Hits 1657 1653 -4
+ Misses 192 191 -1
Partials 40 40
|
olenagerasimova
requested changes
Jun 15, 2023
| CompletableFuture.runAsync(this.updateOther(packages, res)), | ||
| CompletableFuture.runAsync(this.updateFilelist(packages, res)) | ||
| ); | ||
| Append.setPrimaryPckg(temp, res, primary).run(); |
There was a problem hiding this comment.
Append.setPrimaryPckg(temp, res, primary).run() can also be run in parallel
There was a problem hiding this comment.
We also should use this thread.
There was a problem hiding this comment.
hm, I see, maybe we change method return type to void? Runnable is not required and seems confusing in such implementation
olenagerasimova
approved these changes
Jun 16, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of #550