[RFC] Change yarn test to run all types of checks that CI would also run

[alloy]

More than once I have pushed code where I forgot to run one of the various test tasks. So rather than yarn test being a synonym for yarn jest, we can have it do yarn type-check && yarn lint && yarn relay && yarn jest. Thoughts?

[alloy]

In the past we would have had a task like yarn ci that would run all of these and would be the task that actually got invoked by CI, but I’m assuming we list them out separately in the Circle config because Circle will then be able to have nice UI for each of those steps (?).

[sarahscott]

I think this is a good idea but in my experience, sometimes yarn ci passes locally and not in Circle, and I think it's always been linting or prettier-related.

[alloy]

@sarahscott To be fair, isn’t that because you maybe don’t have the git commit hook setup to automatically run the linter/prettier?

[mennenia]

Yes! 🙌 I agree whole heartedly

[alloy]

@sarahscott Maybe there’s a way to also run prettier and rather than write changes exit with a failure status? If so, then that could be added to the yarn test task as well, assuming it doesn’t take too long to run.

[sarahscott]

@alloy I ran prettier and linter manually, so it wouldn't have been related to a git hook.

[alloy]

@sarahscott Next time that it happens, try to nail down how that discrepancy could’ve occurred and then let’s fix it permanently.

[l2succes]

No strong opinion, I've been using yarn ci for that purpose and since yarn test would essentially be the same set of commands minus yarn prettier-project I'm fine with it.

[orta]

This repo is behind culturally in how we manage git hooks - #905

In Danger and Peril I run all of the tests/linters before a push, Emission should do this too. Considering how easy/fast it is to run this stuff and how much time it takes to get that eventual feedback after the PR then CI results.

[orta]

I’m assuming we list them out separately in the Circle config because Circle will then be able to have nice UI for each of those steps.

Yep

[katarinabatina]

tracked in Jira https://artsyproduct.atlassian.net/browse/IN-15