Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preparations for use in Relay #134

Closed
3 of 5 tasks
broskoski opened this issue Mar 4, 2016 · 6 comments
Closed
3 of 5 tasks

Preparations for use in Relay #134

broskoski opened this issue Mar 4, 2016 · 6 comments

Comments

@broskoski
Copy link
Contributor

broskoski commented Mar 4, 2016

I haven't researched at all what is needed here, but whatever work is needed to make metaphysics work nicely with Relay will be needed for both web and mobile.


[Updated by @alloy]

  • Add Global Object Identification.
    • Need to change the id fields to be a composite key, so that the type and specific instance can be inflected from it. E.g. Artist#banksy. The common implementation deployed in the GraphQL community also Base64 encodes that key.
    • Ensure existing clients use the appropriate ID field. Which, for those not using Relay atm, means they probably need to use _id, which maps to the Gravity ID. However from short discussion with @joeyAghion, it seems like searching by _id could be a problem, because only some models would support searching by slug on that field. Alternatively we’ll have to add e.g. gravityID, which would be the equivalent of id right now.
  • Expose associations as connections, which allow for slicing and paginating.
  • See if we need to do anything else to support deferring query fragments.
@dzucconi
Copy link
Member

dzucconi commented Mar 4, 2016

@alloy
Copy link
Contributor

alloy commented Mar 4, 2016

Aye aye. So basically, since our current sprint where the new artist view is scheduled is slated for 21st of March, this means I’d need to be able to use Relay with metaphysics before then, e.g. 16th.

@orta
Copy link
Contributor

orta commented May 25, 2016

@alloy where did this end up ( I know we use relay in Eigen now )

@alloy
Copy link
Contributor

alloy commented May 26, 2016

We do use Relay, but there are certain features we can’t use yet. I will update the original comment with a TODO list.

@alloy
Copy link
Contributor

alloy commented May 26, 2016

@mzikherman Can you shed some light on that issue with _id on Gravity supporting search by slug, but only on some models?

@alloy alloy closed this as completed Jul 19, 2016
@alloy
Copy link
Contributor

alloy commented Jul 19, 2016

Moved connections part to a new ticket #367

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants