Skip to content
This repository has been archived by the owner. It is now read-only.

Create a tool that fails CI based on the PR itself #31

Closed
orta opened this issue Apr 22, 2015 · 12 comments
Closed

Create a tool that fails CI based on the PR itself #31

orta opened this issue Apr 22, 2015 · 12 comments
Labels

Comments

@orta
Copy link
Contributor

@orta orta commented Apr 22, 2015

So, you'd write a DSL which is given a few ivars e.g: lines_of_code, pr_url, number_of_commits, files_modified, files_added, files_removed

Culturefile:

if (lines_of_code > 20) && (files_modified.includes? "CHANGELING.yml" == false) {
    fail "needs to have a changelog note for large changes"
}

if (files_added.length > 2) && (files_modified.includes? "ARAppDelegate+Analytics" == false)  {
    warn "You may want analytics"
}
@neonichu
Copy link

@neonichu neonichu commented Apr 22, 2015

CHANGELING.yml 😻

@orta
Copy link
Contributor Author

@orta orta commented Apr 22, 2015

best kinds of YANIMALS

@getaaron
Copy link

@getaaron getaaron commented Apr 22, 2015

Should < be >?

@orta
Copy link
Contributor Author

@orta orta commented Apr 22, 2015

I don't really care about the actual code in there, it's just pseudo code to demonstrate the potential idea.

@orta
Copy link
Contributor Author

@orta orta commented Jul 4, 2015

This can be grabbed now in:

  • travis: via the ENV vars: TRAVIS_REPO_SLUG and TRAVIS_PULL_REQUEST
  • circle: via CI_PULL_REQUEST which is the full URL
@orta
Copy link
Contributor Author

@orta orta commented Jul 4, 2015

Talked it over with Danger, she thinks it should be called Columbo, and be that "one more thing" thing, with one of these GIFs. Given that there's already a ruby gem called columbo, I'll use brew and write in swift. Only wish there was a dependency manager that could do swift command line tools.

@ashfurrow
Copy link
Member

@ashfurrow ashfurrow commented Jul 4, 2015

Nice – good idea! I'd suggest running it early in the CI process so that it fails quickly.

@orta
Copy link
Contributor Author

@orta orta commented Sep 3, 2015

@orta
Copy link
Contributor Author

@orta orta commented Sep 29, 2015

This has started development at https://github.com/orta/danger

@ashfurrow
Copy link
Member

@ashfurrow ashfurrow commented Sep 29, 2015

@orta
Copy link
Contributor Author

@orta orta commented Oct 24, 2015

@orta
Copy link
Contributor Author

@orta orta commented Feb 10, 2016

This is definitely good enough. Long live danger.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
4 participants
You can’t perform that action at this time.