New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a tool that fails CI based on the PR itself #31

Closed
orta opened this Issue Apr 22, 2015 · 12 comments

Comments

Projects
None yet
4 participants
@orta
Member

orta commented Apr 22, 2015

So, you'd write a DSL which is given a few ivars e.g: lines_of_code, pr_url, number_of_commits, files_modified, files_added, files_removed

Culturefile:

if (lines_of_code > 20) && (files_modified.includes? "CHANGELING.yml" == false) {
    fail "needs to have a changelog note for large changes"
}

if (files_added.length > 2) && (files_modified.includes? "ARAppDelegate+Analytics" == false)  {
    warn "You may want analytics"
}
@neonichu

This comment has been minimized.

Show comment
Hide comment
@neonichu

neonichu Apr 22, 2015

CHANGELING.yml 😻

neonichu commented Apr 22, 2015

CHANGELING.yml 😻

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Apr 22, 2015

Member

best kinds of YANIMALS

Member

orta commented Apr 22, 2015

best kinds of YANIMALS

@getaaron

This comment has been minimized.

Show comment
Hide comment
@getaaron

getaaron Apr 22, 2015

Should < be >?

getaaron commented Apr 22, 2015

Should < be >?

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Apr 22, 2015

Member

I don't really care about the actual code in there, it's just pseudo code to demonstrate the potential idea.

Member

orta commented Apr 22, 2015

I don't really care about the actual code in there, it's just pseudo code to demonstrate the potential idea.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 4, 2015

Member

This can be grabbed now in:

  • travis: via the ENV vars: TRAVIS_REPO_SLUG and TRAVIS_PULL_REQUEST
  • circle: via CI_PULL_REQUEST which is the full URL
Member

orta commented Jul 4, 2015

This can be grabbed now in:

  • travis: via the ENV vars: TRAVIS_REPO_SLUG and TRAVIS_PULL_REQUEST
  • circle: via CI_PULL_REQUEST which is the full URL
@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Jul 4, 2015

Member

Talked it over with Danger, she thinks it should be called Columbo, and be that "one more thing" thing, with one of these GIFs. Given that there's already a ruby gem called columbo, I'll use brew and write in swift. Only wish there was a dependency manager that could do swift command line tools.

Member

orta commented Jul 4, 2015

Talked it over with Danger, she thinks it should be called Columbo, and be that "one more thing" thing, with one of these GIFs. Given that there's already a ruby gem called columbo, I'll use brew and write in swift. Only wish there was a dependency manager that could do swift command line tools.

@ashfurrow

This comment has been minimized.

Show comment
Hide comment
@ashfurrow

ashfurrow Jul 4, 2015

Member

Nice – good idea! I'd suggest running it early in the CI process so that it fails quickly.

Member

ashfurrow commented Jul 4, 2015

Nice – good idea! I'd suggest running it early in the CI process so that it fails quickly.

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Sep 29, 2015

Member

This has started development at https://github.com/orta/danger

Member

orta commented Sep 29, 2015

This has started development at https://github.com/orta/danger

@ashfurrow

This comment has been minimized.

Show comment
Hide comment
@ashfurrow
Member

ashfurrow commented Sep 29, 2015

@orta

This comment has been minimized.

Show comment
Hide comment
@orta

This comment has been minimized.

Show comment
Hide comment
@orta

orta Feb 10, 2016

Member

This is definitely good enough. Long live danger.

Member

orta commented Feb 10, 2016

This is definitely good enough. Long live danger.

@orta orta closed this Feb 10, 2016

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment