Create a tool that fails CI based on the PR itself

[orta]

So, you'd write a DSL which is given a few ivars e.g: lines_of_code, pr_url, number_of_commits, files_modified, files_added, files_removed

Culturefile:

if (lines_of_code > 20) && (files_modified.includes? "CHANGELING.yml" == false) {
    fail "needs to have a changelog note for large changes"
}

if (files_added.length > 2) && (files_modified.includes? "ARAppDelegate+Analytics" == false)  {
    warn "You may want analytics"
}

[neonichu]

CHANGELING.yml 😻

[orta]

best kinds of YANIMALS

[getaaron]

Should < be >?

[orta]

I don't really care about the actual code in there, it's just pseudo code to demonstrate the potential idea.

[orta]

This can be grabbed now in:

• travis: via the ENV vars: TRAVIS_REPO_SLUG and TRAVIS_PULL_REQUEST
• circle: via CI_PULL_REQUEST which is the full URL

[orta]

Talked it over with Danger, she thinks it should be called Columbo, and be that "one more thing" thing, with one of these GIFs. Given that there's already a ruby gem called columbo, I'll use brew and write in swift. Only wish there was a dependency manager that could do swift command line tools.

[ashfurrow]

Nice – good idea! I'd suggest running it early in the CI process so that it fails quickly.

[orta]

Would be nice to mix with https://github.com/blog/2051-protected-branches-and-required-status-checks

[orta]

This has started development at https://github.com/orta/danger

[ashfurrow]

[orta]

Related: http://techlife.cookpad.com/entry/2015/06/04/dokumi-en

[orta]

This is definitely good enough. Long live danger.