Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(record): add --stash flag #1150

Merged
merged 1 commit into from
Dec 31, 2023
Merged

feat(record): add --stash flag #1150

merged 1 commit into from
Dec 31, 2023

Conversation

YakoYakoYokuYoku
Copy link
Contributor

Because I need to stash things and git stash falls short I've created this PR. Fixes #979.

arxanas
arxanas requested changes Dec 17, 2023
View reviewed changes
Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Could you add a test to git-branchless-record/tests/test_record.rs? It looks like we would want to verify the behavior both with a branch checked out and without one.

git-branchless-record/src/lib.rs Outdated Show resolved Hide resolved
@YakoYakoYokuYoku YakoYakoYokuYoku force-pushed the record-stash branch 4 times, most recently from 09fcd0d to 11cf7c8 Compare December 23, 2023 15:53
@arxanas arxanas mentioned this pull request Dec 27, 2023
Closed
arxanas
arxanas approved these changes Dec 30, 2023
View reviewed changes
Copy link
Owner

@arxanas arxanas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks for implementing! I just had one comment on the doc-string.

It looks like linting/static analysis is failing (probably due to an upgrade in Clippy nightly). I'll fix that on master, then you can rebase on top of it and land this commit.

git-branchless-opts/src/lib.rs Outdated Show resolved Hide resolved
@arxanas arxanas merged commit a51285a into arxanas:master Dec 31, 2023
13 checks passed
@YakoYakoYokuYoku YakoYakoYokuYoku deleted the record-stash branch January 1, 2024 04:54
@abusch abusch mentioned this pull request May 27, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arxanas arxanas arxanas approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@YakoYakoYokuYoku @arxanas