Convert axis-angle to rotation matrix then to Euler angles in csparc2star #5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alipunjani
changed the title
asarnow
added a commit
that referenced
this pull request
Apr 26, 2017
code provided by Ali Punjani in #5. csparc2star.py now outputs correct Euler angles which give a correct result from relion_reconstruct.
|
Thanks, Ali! The program outputs correct angles now. |
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This code hasn't been tested but hopefully should work. At least the math should be correct.
The
expmapfunction is from cryoSPARC, converts axis-angle to rotation matrix. Then theutil.rot2eulerconverts that to Euler angles in the Relion format.This should at least give Euler angles for particles that are correct relative to eachother, but I suspect there's still going to be a flip or 90-degree rotation somewhere that is missing for the angles to be correct relative to a .mrc file output from cryoSPARC.