Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

translate README to Chinese #113

Merged
merged 6 commits into from
Jun 12, 2016
Merged

translate README to Chinese #113

merged 6 commits into from
Jun 12, 2016

Conversation

diguage
Copy link
Contributor

@diguage diguage commented Jun 1, 2016

No description provided.

@diguage
Copy link
Contributor Author

diguage commented Jun 2, 2016

Why have all checks failed?

@pepijnve
Copy link
Member

pepijnve commented Jun 2, 2016

Unrelated issues. Trying to get all tests working on Travis and Appveyor. That requires two versions of phantomjs in parallel.

@pepijnve
Copy link
Member

pepijnve commented Jun 2, 2016

Thanks for making this translation btw. I'm a little bit reluctant to merge this since it's something I can't maintain myself and I'm worried it will be out of sync with the English README all the time.
@mojavelinux do you have translations for Asciidoctor documentation? If so, how do you keep all translations in sync?

@diguage
Copy link
Contributor Author

diguage commented Jun 2, 2016

Now, I write my documents with Asciidoctor. I like Asciidoctor. So, I'll keep Chinese translations in sync.

I want to introduce Asciidoctor to Chinese poeple. I am translating all the Asciidoctor documents to Chinese. asciidoctor/asciidoctor.org#585

I translated the README of Asciidoctor to Chinese. asciidoctor/asciidoctor#1772

@mojavelinux
Copy link
Member

If found the secret to keeping translations up to date is simply a good relationship with the community. There's no silver bullet, aside from dedicated people. Human powered ;)

I asked @diguage to send the translation here as part of an ongoing effort to add translations to asciidoctor.org. I would much rather have the translation in the upstream project than sitting downstream in asciidoctor.org, which really should just be a documentation aggregator.

To help make it clear who the current maintainer of the translation is, it's important to have the field "translator" (or "translators") in the AsciiDoc header, perhaps even shown at the top of the page like we do at http://arquillian.org/guides/getting_started_zh_cn/. If an issue comes in to update the README, just mention the translator to give that person a chance to update.

@diguage
Copy link
Contributor Author

diguage commented Jun 3, 2016

I added the issue about translator field asciidoctor/asciidoctor#1755.

@mojavelinux
Copy link
Member

You don't need to wait on a change in core to add the translators. Just add it to the metadata to the header:

:translators: D瓜哥

Then reference it somewhere in the text:

ifdef::env-github[Translated by: {translators}]

When we render it on the website, we might decide to place it somewhere more strategic, which is why I put it behind a conditional.

@mojavelinux
Copy link
Member

What's important is to get the information into the document. We can always deal with how we show it later.

@diguage
Copy link
Contributor Author

diguage commented Jun 4, 2016

The checks have failed. How to resolve the problem?

@pepijnve
Copy link
Member

pepijnve commented Jun 4, 2016

You don't need to fix these. These are due to failures on master that I need to fix.

@diguage
Copy link
Contributor Author

diguage commented Jun 8, 2016

There is the discussion about the disclamer: asciidoctor/asciidoctor-maven-plugin#223

@pepijnve pepijnve merged commit eec09b2 into asciidoctor:master Jun 12, 2016
@pepijnve
Copy link
Member

Sorry for the delay in merging this PR. I've been swamped with other tasks and simply didn't find the time to get this done until now.

@mojavelinux
Copy link
Member

👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants