Update asciidoctor-revealjs to 5.0.0.rc1 #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
can't actually find good way to test this properly as gradle publishtomavenlocal requires signing ....any way to do such without having signing configured? |
|
I did get it to work using the java api via jbang. so marking this ready for review - but as stated above I can't test it fully as couldn't find way to publish locally to test with maven etc. |
|
Thank you so much! 🙌 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for opening a pull request and contributing to AsciidoctorJ!
Please take a bit of time giving some details about your pull request:
Kind of change
[ ] Bug fix
[ ] New non-breaking feature
[X] New breaking feature
[X] Documentation update
[ ] Build improvement
Description
What is the goal of this pull request?
update to 5.0.0.rc1 so can have a jvm version of latest revealjs
How does it achieve that?
update dependencies + fix test assumptions
Are there any alternative ways to implement this?
no
Are there any implications of this pull request? Anything a user must know?
all in docs.
Release notes
Please add a corresponding entry to the file CHANGELOG.adoc