Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not check CI badges #944

Merged
merged 1 commit into from
Jan 10, 2024
Merged

fix: do not check CI badges #944

merged 1 commit into from
Jan 10, 2024

Conversation

janpieper
Copy link
Contributor

Summary

See #943.

This PR removes the check for the CI badges from the scripts/test_plugin.bash script, because they have been removed.

Checklist

  • Format with scripts/format.bash
  • Test locally:
    • with scripts/test_plugin.bash --file plugins/elixir
    • with scripts/test_plugin.bash --file plugins/erlang
    • ...
  • Your plugin CI tests are green

they have been removed by 15dadb1
@janpieper janpieper requested a review from a team as a code owner January 10, 2024 08:15
Copy link
Contributor

@jthegedus jthegedus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great, thanks!

@jthegedus jthegedus merged commit f357862 into asdf-vm:master Jan 10, 2024
3 checks passed
@janpieper janpieper deleted the do-not-check-for-ci-badges-anymore branch January 10, 2024 13:31
mbutov pushed a commit to mbutov/asdf-plugins that referenced this pull request May 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants