WIP initial attempt at tag userdata, does not work #2265
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrameTagPropertiesCommand::onExecute returns unexpectedly. Attempts to debug with gdb have met with limited success and much confusion.
|
Hi @sparr, please check the CLA signing process. |
|
I will try to review this PR soon and try to integrated it into |
|
dose this also address the problems with tags and scripting as mentioned here: #2487 ? |
|
About this PR we will merge some of these changes + fixes for the future release v1.3. Thanks @sparr |
|
You're welcome. Thanks for taking a look. I am glad at least some of this will be of use. I wish I had been able to see this through to completion. |
|
I'm reviewing some old PRs, this was finally merged with 55a37d0 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My goal here is to add userdata functionality to tags, as currently exists for cels, layers, and slices. The biggest hiccup was that the tag properties window isn't as fancifully defined as the others, but I think I got over that. Now everything works fine up until you actually change the userdata on a tag, at which point the change doesn't save. I would appreciate any insight on what bit of functionality I might have missed implementing.