feat(auth-components): add prop support & add more compound components for SignIn Component #12
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
movinsilva
force-pushed
the
auth-components--prop-support
branch
from
0e7e512 to
ddcc908
Compare
dasuni-30
reviewed
May 13, 2024
packages/react/src/oxygen-ui-react-auth-components/SignIn/SignIn.tsx
Outdated
Show resolved
Hide resolved
dasuni-30
reviewed
May 13, 2024
packages/react/src/oxygen-ui-react-auth-components/SignInFooter/SignInFooter.tsx
Show resolved
Hide resolved
brionmario
reviewed
May 13, 2024
packages/react/src/oxygen-ui-react-auth-components/SignInButton/sign-in-button.scss
Show resolved
Hide resolved
brionmario
reviewed
May 13, 2024
| color: grey; | ||
|
|
||
| .OxygenSignInLink { | ||
| color: grey; |
There was a problem hiding this comment.
Shall we use a oxygen variable? so that it works when switching themes?
There was a problem hiding this comment.
updated with bc928d3
brionmario
reviewed
May 13, 2024
| color: grey; | ||
|
|
||
| &:hover { | ||
| color: #ff7300; |
There was a problem hiding this comment.
Shall we use an oxygen variable? so that it works when switching themes?
Hope this is the primary color?
There was a problem hiding this comment.
updated with bc928d3
brionmario
reviewed
May 13, 2024
packages/react/src/oxygen-ui-react-auth-components/SignInImage/sign-in-image.scss
Show resolved
Hide resolved
brionmario
reviewed
May 13, 2024
| */ | ||
|
|
||
| .OxygenSignInTypography-subtitle { | ||
| color: grey; |
There was a problem hiding this comment.
updated with d8f21aa
brionmario
approved these changes
May 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
- SignInImage
- SignInFooter
- SignInPinInput
Related Issues
Related PRs
Checklist
Security checks