-
Notifications
You must be signed in to change notification settings - Fork 33
chore: add Français - fr-FR
language support
#188
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: add Français - fr-FR
language support
#188
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @lemeurherve, thank you for the contribution. Shall we add the changeset too?
Hello @pavinduLakshan, I may have missed something, but what do you mean by "add the changeset too"? |
Hi @lemeurherve, a changeset is a file in a specific format that lists the packages modified in a pull request. This ensures that only the changed packages are released. We’ve updated the contribution guide with more details on changesets and instructions on how to include one in a pull request[1]. [1] https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#releases |
@pavinduLakshan thanks for the additional info, changeset added in ed1aefc, let me know if it looks fine to you. |
🦋 Changeset detectedThe changes in this PR will be included in the next version bump. Not sure what this means? Click here to learn what changesets are. |
@pavinduLakshan the lint & unit test issues are unrelated to my changes. Any advice? |
Since the packages are still in the pre-release phase, we are not prioritizing lint issues at this time. These will be addressed as part of a separate effort. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks for the contribution, @lemeurherve. It’s been a pleasure collaborating with you to get this merged.
Purpose
This PR adds
Français - fr-FR
language supportRelated Issues
Français - fr-FR
language support #156Related PRs
Checklist
Security checks