Skip to content

Conversation

lemeurherve
Copy link
Contributor

@lemeurherve lemeurherve commented Sep 30, 2025

Purpose

This PR adds Français - fr-FR language support

Related Issues

Related PRs

  • N/A

Checklist

  • Followed the CONTRIBUTING guidelines.
  • Manual test round performed and verified.
  • Documentation provided. (Add links if there are any)
  • Unit tests provided. (Add links if there are any)

Security checks

Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @lemeurherve, thank you for the contribution. Shall we add the changeset too?

@lemeurherve
Copy link
Contributor Author

Hello @pavinduLakshan, I may have missed something, but what do you mean by "add the changeset too"?

@pavinduLakshan
Copy link
Contributor

Hello @pavinduLakshan, I may have missed something, but what do you mean by "add the changeset too"?

Hi @lemeurherve, a changeset is a file in a specific format that lists the packages modified in a pull request. This ensures that only the changed packages are released. We’ve updated the contribution guide with more details on changesets and instructions on how to include one in a pull request[1].

[1] https://github.com/asgardeo/javascript/blob/main/CONTRIBUTING.md#releases

@lemeurherve
Copy link
Contributor Author

@pavinduLakshan thanks for the additional info, changeset added in ed1aefc, let me know if it looks fine to you.

@asgardeo-github-bot
Copy link

🦋 Changeset detected

The changes in this PR will be included in the next version bump.

Not sure what this means? Click here to learn what changesets are.

@lemeurherve
Copy link
Contributor Author

lemeurherve commented Oct 1, 2025

@pavinduLakshan the lint & unit test issues are unrelated to my changes. Any advice?

@pavinduLakshan
Copy link
Contributor

@pavinduLakshan the lint & unit test issues are unrelated to my changes. Any advice?

Since the packages are still in the pre-release phase, we are not prioritizing lint issues at this time. These will be addressed as part of a separate effort.

Copy link
Contributor

@pavinduLakshan pavinduLakshan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Thanks for the contribution, @lemeurherve. It’s been a pleasure collaborating with you to get this merged.

@pavinduLakshan pavinduLakshan merged commit 47454b6 into asgardeo:main Oct 1, 2025
3 of 5 checks passed
@lemeurherve lemeurherve deleted the issue156-add-fr-translation branch October 1, 2025 12:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants