Skip to content

feat(react): add unique class names for social login buttons #26

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 22, 2024
Merged

feat(react): add unique class names for social login buttons #26

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0ee03eb
feat(react): :lipstick: add unique class names for social login buttons
movinsilva May 22, 2024
26af797
refactor(react): :lipstick: update class name format of buttons
movinsilva May 22, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions packages/react/src/components/SignIn/SignIn.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -306,7 +306,7 @@ const SignIn: FC<SignInProps> = (props: SignInProps): ReactElement => {
*/
if (isComponentLoading || isLoading || authContext.isBrandingLoading) {
return (
<div className="circular-progress-holder">
<div className="Box-circularProgressHolder">
<CircularProgress className="circular-progress" />
</div>
);
Expand All @@ -322,7 +322,7 @@ const SignIn: FC<SignInProps> = (props: SignInProps): ReactElement => {

return (
<ThemeProvider theme={generateThemeSignIn(componentBranding?.preference.theme)}>
<UISignIn className="asgardeo-sign-in">
<UISignIn className="Box-asgardeoSignIn">
{showLogo && !(isLoading || isComponentLoading) && (
<UISignIn.Image className="asgardeo-sign-in-logo" src={imgUrl} />
)}
Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/components/SignIn/fragments/BasicAuth.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,8 +71,8 @@ const BasicAuth = ({
}

return (
<UISignIn.Paper className="asgardeo-basic-auth-paper">
<UISignIn.Typography title className="basic-auth-title">
<UISignIn.Paper className="Paper-basicAuth">
<UISignIn.Typography title className="Typography-basicAuthTitle">
{t(keys.login.login.heading)}
</UISignIn.Typography>

Expand Down
1 change: 1 addition & 0 deletions packages/react/src/components/SignIn/fragments/LoginOptionsBox.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,6 +53,7 @@ const LoginOptionsBox = ({
handleOnClick,
}: LoginOptionsBoxProps): ReactElement => (
<UISignIn.Button
className={`Button-${socialName.toLowerCase()}`}
social
startIcon={<img className="social-login-img" src={images[socialName]} alt={socialName} />}
onClick={handleOnClick}
Expand Down
2 changes: 1 addition & 1 deletion packages/react/src/components/SignIn/fragments/basic-auth.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@
}
}

.asgardeo-basic-auth-paper {
.Paper-basicAuth {
opacity: 0.5;
animation: fade-in 0.9s ease-in-out forwards;

Expand Down
4 changes: 2 additions & 2 deletions packages/react/src/components/SignIn/sign-in.scss
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,7 @@
*/
$--min-height: 75vh;

.asgardeo-sign-in {
.Box-asgardeoSignIn {
min-width: 350px;
min-height: $--min-height;

Expand All @@ -38,7 +38,7 @@ $--min-height: 75vh;
}
}

.circular-progress-holder {
.Box-circularProgressHolder {
display: flex;
justify-content: center;
align-items: center;
Expand Down