fix: remove unnecessary warning for recursive embedded types #386
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The warning "Detected recursive embedded type" was being logged when processing self-referential embedded resources in OpenAPI schema generation. This is expected behavior - the code correctly handles recursion by using $ref references. The warning was misleading since it made it seem like something was wrong when the recursion was being handled properly.
|
🚀 Thank you for your contribution! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Removes the unnecessary warning that appears when processing recursive embedded resources in OpenAPI schema generation. The code already correctly handles recursion by using
$refreferences, so the warning is misleading and makes it seem like something is wrong when the behavior is actually expected and properly handled.Changes
Logger.warningcall inlib/ash_json_api/json_schema/open_api.exwhen detecting recursive embedded typestest/acceptance/json_schema_test.exsto remove log capture and warning assertion