Generate generic builder setters for fields taking an objecttype
#724
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
MarijnS95
force-pushed
the
builders-object-trait
branch
from
649c749
to
b5daee5
Compare
MarijnS95
changed the title
objecttypeobjecttype
MarijnS95
force-pushed
the
builders-object-trait
branch
from
b5daee5
to
a6a0ecd
Compare
We already do this for hand-written extension functions but can now also implement it for setters since `vk_parse` fields are available within the builder generator code: when a field refers to another field for setting its `objecttype`, that `VkObjectType` field setter is omitted and instead assigned when the object is set, based on a type generic that implements the `Handle` trait instead of an untyped `u64`.
MarijnS95
force-pushed
the
builders-object-trait
branch
from
a6a0ecd
to
2bffd19
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We already do this for hand-written extension functions but can now also implement it for setters since
vk_parsefields are available within the builder generator code: when a field refers to another field for setting itsobjecttype, thatVkObjectTypefield setter is omitted and instead assigned when the object is set, based on a type generic that implements theHandletrait instead of an untypedu64.Note that most of this diff is merely code motion: some necessary cleanups such as replacing tuples with infinitely-more-self-descriptive structs.