extensions/khr: Take the remaining p_next
-containing structs as &mut
#744
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #740
Version 2 of
get_physical_device_surface_capabilities
and the matchingvk::SurfaceCapabilitiesKHR
struct exist solely to provide ansType
andpNext
field to allow extending the original query with additional data via extension structs. However, this API when introduced in #530 only returns thedefault()
-initialized struct making it just as constrained asget_physical_device_surface_capabilities()
. Solve this by takingvk::SurfaceCapabilities2KHR
as&mut
just like any similar API.And just like this, do the same for the remaining:
AccelerationStructure::get_acceleration_structure_build_sizes()
ExternalMemoryFd::get_memory_fd_properties()
ExternalMemoryWin32::get_memory_win32_handle_properties()
In case these structs get extended somewhere down the line, which the Vulkan API allows for.