Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

E57SimpleWriter: Add deprecation notice to old Writer constructor #117

Merged
merged 1 commit into from
Oct 4, 2022
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 6 additions & 3 deletions include/E57SimpleWriter.h
Original file line number Diff line number Diff line change
Expand Up @@ -46,12 +46,15 @@ namespace e57
{
public:
//! @brief This function is the constructor for the writer class
//! @param [in] filePath file path to E57 file
//! @param [in] filePath Path to E57 file
//! @param [in] coordinateMetadata Information describing the Coordinate Reference System to be used for the file
Writer( const ustring &filePath, const ustring &coordinateMetadata = {} );
//! @deprecated Will be removed in 4.0. Use Writer( const ustring &filePath, const WriterOptions &options )
//! instead.
[[deprecated( "Will be removed in 4.0. Use Writer( ustring, WriterOptions )." )]] // TODO Remove in 4.0
explicit Writer( const ustring &filePath, const ustring &coordinateMetadata = {} );

//! @brief This function is the constructor for the writer class
//! @param [in] filePath file path to E57 file
//! @param [in] filePath Path to E57 file
//! @param [in] options Options to be used for the file
Writer( const ustring &filePath, const WriterOptions &options );

Expand Down