Skip to content

Conversation

mattem
Copy link
Collaborator

@mattem mattem commented Oct 16, 2024

Drops the dependency on rattler_installs_packages in favour of the uv crates.

Note that while this works, the creates of uv do not officially support depending directly on the crates, however there is little overhead here, and is pinned to a fixed SHA.

Closes #307
Closes #344
Closes #345

Due to compilation issues under llvm, this diff also switches to musl for the toolchain binaries. We need to keep llvm for proc macros, unfortunately.


Changes are visible to end-users: yes

  • Searched for relevant documentation and updated as needed: yes
  • Breaking change (forces users to change their own code or config): no
  • Suggested release notes appear below: yes

Drop dependency on rattler_installs_packages in favour of the uv crates.
Produce statically linked toolchain binaries via musl.

Test plan

  • New test cases added

@mattem mattem requested review from alexeagle and thesayyn October 16, 2024 18:49
@mattem mattem force-pushed the use_uv branch 7 times, most recently from d342a19 to 90b5ee4 Compare October 16, 2024 22:40
@mattem mattem force-pushed the use_uv branch 4 times, most recently from ab35b21 to 32e71f8 Compare October 22, 2024 15:56
@mattem mattem force-pushed the use_uv branch 4 times, most recently from 2540e02 to ae4c9f7 Compare October 24, 2024 17:07
@mattem mattem mentioned this pull request Oct 24, 2024
@mattem mattem requested a review from illicitonion October 24, 2024 17:22
@mattem mattem merged commit ca62068 into main Oct 24, 2024
11 of 12 checks passed
@mattem mattem deleted the use_uv branch October 24, 2024 18:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[FR]: Switch to uv for venv creation and for pip compile [FR]: include (de)activation scripts in venvs
2 participants