Skip to content

fix: fix multi version example #434

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

fix: fix multi version example #434

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion MODULE.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,7 +21,7 @@ bazel_dep(name = "platforms", version = "0.0.7")
python = use_extension("@rules_python//python/extensions:python.bzl", "python", dev_dependency = True)
python.toolchain(
is_default = False,
python_version = "3.8.12",
python_version = "3.12.0",
)

tools = use_extension("//py:extensions.bzl", "py_tools")
Expand Down
6 changes: 3 additions & 3 deletions WORKSPACE
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -25,11 +25,11 @@ register_toolchains("//:container_py_toolchain")
load("@rules_python//python:repositories.bzl", "py_repositories", "python_register_toolchains")

python_register_toolchains(
name = "python_toolchain_3_8",
python_version = "3.8.12",
name = "python_toolchain_3_12",
python_version = "3.12.0",
# Setting `set_python_version_constraint` will set special constraints on the registered toolchain.
# This means that this toolchain registration will only be selected for `py_binary` / `py_test` targets
# that have the `python_version = "3.8.12"` attribute set. Targets that have no `python_attribute` will use
# that have the `python_version = "3.12.0"` attribute set. Targets that have no `python_attribute` will use
# the default toolchain resolved which can be seen below.
set_python_version_constraint = True,
)
Expand Down
4 changes: 2 additions & 2 deletions examples/multi_version/BUILD.bazel
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@ py_binary(
deps = [
"@pypi_cowsay//:pkg",
],
python_version = "3.8.12"
python_version = "3.12.0"
)
py_pytest_main(
name = "__test__",
Expand All @@ -23,7 +23,7 @@ py_test(
deps = [
":__test__",
],
python_version = "3.8.12"
python_version = "3.12.0"
)
py_test(
name = "py_version_default_test",
Expand Down
4 changes: 2 additions & 2 deletions examples/multi_version/py_version_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,5 +2,5 @@

def test_specific_py_version():
assert sys.version_info.major == 3, "sys.version_info.major == 3"
assert sys.version_info.minor == 8, "sys.version_info.minor == 8"
assert sys.version_info.micro == 12, "sys.version_info.micro == 12"
assert sys.version_info.minor == 12, "sys.version_info.minor == 12"
assert sys.version_info.micro == 0, "sys.version_info.micro == 0"