Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Please add a new parameter BtchBookg #2

Closed
MicrotronX opened this issue Jul 30, 2018 · 3 comments
Closed

Please add a new parameter BtchBookg #2

MicrotronX opened this issue Jul 30, 2018 · 3 comments

Comments

@MicrotronX
Copy link
Contributor

We need the "BtchBookg" parameter in XML output. We have changed source on our side, please add it to your code:

TCreditTransferPaymentInformation = class
private
...
fBtchBookg:string; // set it to "false" in onCreate
public
...
property BtchBookg: String read fBtchBookg write fBtchBookg;
...

and write it to XML right after "PmtMtd"

procedure TCreditTransferPaymentInformation.SaveToStream(const stream: TStream; const schema: String);
begin
SEPAWriteLine(stream, '');
SEPAWriteLine(stream, ''+SEPACleanString(PmtInfId)+'');
SEPAWriteLine(stream, ''+SEPACleanString(PmtMtd)+'');

//>>
SEPAWriteLine(stream, ''+SEPACleanString(fBtchBookg)+'');

@aspettl
Copy link
Owner

aspettl commented Jul 31, 2018

Thanks, it would be great if you can prepare a pull request!

Please note:

  • fBtchBookg should be a boolean
  • direct debit should support batch booking as well
  • unit tests should be adjusted/extended accordingly

This makes it a lot easier for me to accept changes quickly.

If you want to contribute directly: note that I just switched to a dual-license of Apache 2.0 or GPLv2-or-later.

@MicrotronX
Copy link
Contributor Author

I'm not allowed to create a pull request.

@aspettl
Copy link
Owner

aspettl commented Aug 6, 2018

Fixed by #4

@aspettl aspettl closed this as completed Aug 6, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants