Skip to content

Conversation

MackinnonBuck
Copy link
Member

@MackinnonBuck MackinnonBuck commented Oct 16, 2024

The benchmarks were failing because npm install attempted to auto-update the package-lock.json file, which failed due to npm login not succeeding.

This PR fixes the problem by:

  1. Updating the package-lock.json file manually
  2. Changing the Dockerfile to run npm ci to guarantee that changes to package-lock.json don't get made automatically

Fixes dotnet/aspnetcore#58424

@MackinnonBuck
Copy link
Member Author

Verified changes by running:

crank --config https://raw.githubusercontent.com/aspnet/Benchmarks/mbuck/update-lighthouse-deps/scenarios/blazor.benchmarks.yml --scenario blazorWebInteractiveAuto --profile aspnet-perf-lin --application.framework net9.0 --application.source.branchOrCommit mbuck/update-lighthouse-deps --load.source.branchOrCommit mbuck/update-lighthouse-deps

@sebastienros sebastienros merged commit c8acb90 into main Oct 16, 2024
1 check passed
@sebastienros sebastienros deleted the mbuck/update-lighthouse-deps branch October 16, 2024 21:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[PERF] Lighthouse benchmarks failing
2 participants