Update to latest Razor Slices #2038
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Drop net7 support - Fix TargetFrameworkVersion condition
DamianEdwards
commented
Dec 16, 2024
| loggerFactory.AddConsole(o => o.TimestampFormat = "ss.ffff ").SetMinimumLevel(logLevel); | ||
| loggerFactory | ||
| .AddConsole() | ||
| .AddConsoleFormatter<ConsoleFormatter, ConsoleFormatterOptions>(o => o.TimestampFormat = "ss.ffff") |
There was a problem hiding this comment.
This change was done to resolve an obsolete warning.
DamianEdwards
commented
Dec 16, 2024
| <ItemGroup> | ||
| <PackageReference Include="Grpc.AspNetCore" Version="2.27.0" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Grpc.HttpApi" Version="0.1.0-alpha.20121.1" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Grpc.HttpApi" Version="0.1.0-alpha.20179.2" /> |
There was a problem hiding this comment.
This was done to quiet a NuGet warning about the previous stated version being unresolvable.
DamianEdwards
commented
Dec 16, 2024
| <PackageReference Include="Microsoft.Data.SqlClient" Version="$(MicrosoftDataSqlClientVersion90)" /> | ||
| <PackageReference Include="Microsoft.EntityFrameworkCore.Sqlite" Version="$(MicrosoftEntityFrameworkCoreSqliteVersion90)" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Server.IntegrationTesting.IIS" Version="$(MicrosoftAspNetCoreAppPackageVersion)" /> | ||
| <PackageReference Include="Microsoft.AspNetCore.Server.IntegrationTesting.IIS" Version="$(MicrosoftIISTestingVersion90)" /> |
There was a problem hiding this comment.
Seems this was a typo/copy-pasta that was causing a NuGet warning as the versions didn't line up.
DamianEdwards
commented
Dec 16, 2024
| </ItemGroup> | ||
|
|
||
| <ItemGroup Condition="$([MSBuild]::VersionGreaterThanOrEquals($(TargetFrameworkVersion), '9.0'))"> | ||
| <ItemGroup Condition="$([MSBuild]::IsTargetFrameworkCompatible($(TargetFramework), 'net9.0'))"> |
There was a problem hiding this comment.
This fixes a build error that occurs when building the project without specifying a target framework, e.g. when building from VS 😄
DamianEdwards
commented
Dec 16, 2024
| app.MapGet("/fortunes", async (HttpContext context, Db db) => { | ||
| var fortunes = await db.LoadFortunesRows(); | ||
| var template = (RazorSliceHttpResult<List<Fortune>>)createFortunesTemplate(fortunes); | ||
| var template = (RazorSliceHttpResult<List<Fortune>>)Fortunes.Create(fortunes); |
There was a problem hiding this comment.
Razor Slices generates these template factory classes now.
DamianEdwards
commented
Dec 16, 2024
| using RazorSlices; | ||
|
|
||
| namespace PlatformBenchmarks | ||
| namespace PlatformBenchmarks; |
There was a problem hiding this comment.
Changed to file-scoped namespace declaration on this file.
DamianEdwards
commented
Dec 16, 2024
src/BenchmarksApps/TechEmpower/PlatformBenchmarks/PlatformBenchmarks.binlog
Outdated
Show resolved
Hide resolved
src/BenchmarksApps/TechEmpower/PlatformBenchmarks/BenchmarkApplication.cs
Outdated
Show resolved
Hide resolved
sebastienros
approved these changes
Dec 17, 2024
BrennanConroy
approved these changes
Dec 17, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates the Platform and Minimal TechEmpower benchmarks to the latest Razor Slices release that uses source generators and supports native AOT. Razor Slices doesn't support rendering to
IBufferWriter<byte>anymore so had to changeChunkedBufferWritertoChunkedPipeWriter.Removed the
.net7.0targets as we don't run those anymore and tweaked the version check condition in .csproj files to be compatible with multi-targeting builds.Also fixed the launch settings in the Platform project so it runs from VS.
Results after the change are within the usual noise margins, i.e. ~566K - ~630K RPS: