Constants for status codes, lookup for reason phrases.

[Tratcher]

#174

[Eilon]

Looks lovely

[kevinchalet]

Uur?

[davidfowl]

[kevinchalet]

My 2 cents: the [Status] + code + name pattern is a bit hard to read and I'm not sure it's really useful: if you know the status code, you don't need to rely on a constant to use it. And if you wanna use a constant, that's often because you don't want to play with the status code directly.

[davidfowl]

@PinpointTownes has a point, should me model it after the crazy System.Net enum?

[Tratcher]

The enum naming assumed you (and everyone reading your code) were deeply familiar with the reason phrases and what the resulting status codes would be. If you just use reason phrases people have to guess the matching status code, where if you just use integers they have to guess the matching reason phrase.

I picked the Status404NotFound pattern because it lets you see both parts together for validation. It also lets you use intellisense like a lookup table where you can type in either the status code or the reason phrase and it immediately shows you the other half. It has Status on there because you can't start with digits.

Would you prefer NotFound404? I find that a little odd because it's the opposite of how it shows up in the response and spec. How about S404NotFound?

[Eilon]

I like it just fine the way it is. I view the point of these as being to eliminate what appear to be magic numbers from the code. And I think this does that beautifully.

[Eilon]

And for the record, I strongly dislike the System.Net StatusCode enum because it adds no value at all. It just takes one hard to understand piece of information and hides it behind another hard to understand piece of information.