New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SASS Support in templates #315

Closed
hheexx opened this Issue Sep 16, 2016 · 4 comments

Comments

Projects
None yet
4 participants
@hheexx

hheexx commented Sep 16, 2016

SASS is standard now for modern web apps.

Why not add sass-loader to webpack config in templates?

@MarkPieszak

This comment has been minimized.

Contributor

MarkPieszak commented Sep 16, 2016

In the documentation it's shown how to set it up with webpack it's actually real easy to add in there. I think Steve just didn't want it to be a default, as some people prefer Stylus, or Less, (or even regular css)

https://github.com/aspnet/JavaScriptServices/tree/dev/src/Microsoft.AspNetCore.SpaServices#example-a-simple-webpack-setup-that-builds-typescript

@hheexx

This comment has been minimized.

hheexx commented Sep 16, 2016

Yea, I added it very easily to wabpack.
But I thought it should be in by default.

If you are interested I may submit pull request...

@asadsahi

This comment has been minimized.

asadsahi commented Sep 17, 2016

One of my project based on spa generator uses SCSS, if that helps:

https://github.com/asadsahi/AspNetCoreSpa

Just upgraded to Latest and greatest too (Typescript 2, Webpack 2, Angular 2 Final) :)

@SteveSandersonMS

This comment has been minimized.

Member

SteveSandersonMS commented Sep 19, 2016

Thanks for the suggestion. As per @MarkPieszak's comment, I think this is covered by docs, and we are trying our best to minimise the out-of-the-box concept count, hence not putting this in by default.

It doesn't seem like there is any one de-facto standard way of handling styling these days (about as many people ask about SASS as LESS as PostCSS as SPA-framework-specific styling concerns), so it's tough to say one way is what everyone wants. But as always we'll keep listening to feedback, and if one particular setup becomes much more popular than alternatives, we'll certainly consider making it the template default.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment