Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Update appveyor to run korebuild #1372

Merged
merged 1 commit into from
Nov 3, 2017
Merged

Update appveyor to run korebuild #1372

merged 1 commit into from
Nov 3, 2017

Conversation

natemcmaster
Copy link
Contributor

AppVeyor isn't actually building the repo because the default AppVeyor image is VS 2015, not 2017.

Changes:

  • update appveyor to vs2017
  • execute a default build with korebuild
  • add 'nodejs' as a required toolset in korebuild.json. This ensures nodejs is available on the machine. (Assuming this is required so tests can run)

@natemcmaster natemcmaster changed the title Update appveyor to run build.cmd Update appveyor to run korebuild Nov 3, 2017
SteveSandersonMS
SteveSandersonMS approved these changes Nov 3, 2017
View reviewed changes
Copy link
Member

@SteveSandersonMS SteveSandersonMS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Assuming this runs successfully in the AppVeyor environment, looks great.

@natemcmaster
Copy link
Contributor Author

Yup, CI is green :) https://ci.appveyor.com/project/aspnetci/javascriptservices/build/1.0.573

@natemcmaster natemcmaster merged commit 7bf5516 into dev Nov 3, 2017
@natemcmaster natemcmaster deleted the namc/korebuild branch November 3, 2017 22:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@SteveSandersonMS SteveSandersonMS SteveSandersonMS approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@natemcmaster @SteveSandersonMS @dnfclas