Skip to content
This repository was archived by the owner on Apr 8, 2020. It is now read-only.

Resolve relative Spa Source based on Content Root #1679

Closed
wants to merge 1 commit into from

Conversation

pardahlman
Copy link

This PR closes #1678 by evaluating the provided SourcePath and doing the following:

  1. Detect if path is relative and if so make it relative to the content root (with fallback to current directory)
  2. Evaluate if the now absolute path exists and if not, throw a helpful exception
  3. Using the existing, absolute path to start the NpmScriptRunner

@dnfclas
Copy link

dnfclas commented Jun 9, 2018

CLA assistant check
All CLA requirements met.

@natemcmaster natemcmaster changed the base branch from dev to master July 2, 2018 17:58
@Eilon
Copy link
Contributor

Eilon commented Jan 2, 2019

Hi, this pull request is being closed because this repo is archived and all the source code and issues have been moved to the https://github.com/aspnet/AspNetCore repository. If you would like to send a new PR, you can find the new location for the source code here: https://github.com/aspnet/AspNetCore/tree/master/src/Middleware/NodeServices

Thanks,
Eilon

@Eilon Eilon closed this Jan 2, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants