This repository was archived by the owner on Apr 8, 2020. It is now read-only.
Fixup MSBuild conversion #721
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@natemcmaster, |
|
@SteveSandersonMS I remove the Web Sites projects because of that MSBuild issue. If you still want this to work in VS, we could have two solutions in the file, one that has the Web Site projects (for working in VS) and one without it (for CI builds). |
|
Thanks for this @natemcmaster - it looks great! It's also nice to have the NPM restoration phase implemented here rather than in a hidden SDK, because we might want to swap out |
|
+1 yarn |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a partial fix for the solution not building with MSBuild.
This is blocked by dotnet/msbuild#1767