Set ProblemDetails status field during ObjectResult formatting

aspnet · Jul 19, 2018 · 6d458e6 · 6d458e6
1 parent 36d90c9
commit 6d458e6
Show file tree

Hide file tree

Showing 2 changed files with 37 additions and 0 deletions.
diff --git a/src/Microsoft.AspNetCore.Mvc.Core/ObjectResult.cs b/src/Microsoft.AspNetCore.Mvc.Core/ObjectResult.cs
@@ -50,6 +50,11 @@ public virtual void OnFormatting(ActionContext context)
             if (StatusCode.HasValue)
             {
                 context.HttpContext.Response.StatusCode = StatusCode.Value;
+
+                if (Value is ProblemDetails details && !details.Status.HasValue)
+                {
+                    details.Status = StatusCode.Value;
+                }
             }
         }
     }

diff --git a/test/Microsoft.AspNetCore.Mvc.Core.Test/ObjectResultTests.cs b/test/Microsoft.AspNetCore.Mvc.Core.Test/ObjectResultTests.cs
@@ -61,6 +61,38 @@ public async Task ObjectResult_ExecuteResultAsync_SetsStatusCode()
             Assert.Equal(404, actionContext.HttpContext.Response.StatusCode);
         }
 
+        [Fact]
+        public async Task ObjectResult_ExecuteResultAsync_SetsProblemDetailsStatus()
+        {
+            // Arrange
+            var modelState = new ModelStateDictionary();
+
+            var details = new ValidationProblemDetails(modelState);
+
+            var result = new ObjectResult(details)
+            {
+                StatusCode = StatusCodes.Status422UnprocessableEntity,
+                Formatters = new FormatterCollection<IOutputFormatter>()
+                {
+                    new NoOpOutputFormatter(),
+                },
+            };
+
+            var actionContext = new ActionContext()
+            {
+                HttpContext = new DefaultHttpContext()
+                {
+                    RequestServices = CreateServices(),
+                }
+            };
+
+            // Act
+            await result.ExecuteResultAsync(actionContext);
+
+            // Assert
+            Assert.Equal(StatusCodes.Status422UnprocessableEntity, details.Status.Value);
+        }
+
         private static IServiceProvider CreateServices()
         {
             var services = new ServiceCollection();