Skip to content
This repository has been archived by the owner on Dec 14, 2018. It is now read-only.

RoslynCompilationService does not include path information when compiling cshtml files #869

Closed
pranavkm opened this issue Jul 26, 2014 · 2 comments
Closed

RoslynCompilationService does not include path information when compiling cshtml files #869

pranavkm opened this issue Jul 26, 2014 · 2 comments
Assignees
@pranavkm
Labels
3 - Done bug
Milestone
1.0.0-alpha4

Comments

@pranavkm
Copy link
Contributor

We should set up the SyntaxTree similar to the way it is set up in https://github.com/aspnet/KRuntime/blob/dev/src/Microsoft.Framework.Runtime.Roslyn/RoslynCompiler.cs#L159-L161
@pranavkm pranavkm added the bug label Jul 26, 2014
@pranavkm pranavkm added this to the 6.0.0-beta1 milestone Jul 26, 2014
@davidfowl
Copy link
Member

Also, the compilation options should probably be the same. Maybe we can flow more info from the host

@pranavkm
Copy link
Contributor Author

@davidfowl compilation options bit is tracked via #871

pranavkm added a commit that referenced this issue Jul 28, 2014
@pranavkm
Propogate additional compilation data from RoslynCompilationService
b54ea6b 
* Update CompilationFailedException to include path of file being compiled
* Pass in path being compiled to Rolsyn.
* Adding doc comments for compilation pieces

Fixes #869
@pranavkm pranavkm mentioned this issue Jul 28, 2014
Closed
@pranavkm pranavkm self-assigned this Jul 29, 2014
pranavkm added a commit that referenced this issue Aug 7, 2014
@pranavkm
Propogate additional compilation data from RoslynCompilationService
c0590bf 
* Update CompilationFailedException to include path of file being compiled
* Pass in path being compiled to Rolsyn.
* Adding doc comments for compilation pieces

Fixes #869
@pranavkm pranavkm modified the milestones: 6.0.0-alpha4, 6.0.0-beta1 Aug 29, 2014
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@pranavkm pranavkm

Labels
3 - Done bug
Projects
None yet
Milestone
1.0.0-alpha4
Development

No branches or pull requests
2 participants
@davidfowl @pranavkm