SharedCompilationId is not supported by Csc Task

[jaredpar]

This is ported from dotnet/roslyn#24542

When upgrading to Dev15.6 web projects using the DotNetCompilerPlatform package will get the following error when building:

error MSB4064: The "SharedCompilationId" parameter is not supported by the "Csc" task. Verify the parameter exists on the task, and it is a settable public instance property.
29>C:\Program Files (x86)\Microsoft Visual

This appears to be due to the new parameter, SharedCompilationId, being added to the C# targets but not being present in the Csc Task that is loaded by the DotNetCompilerPlatform. Hence when upgrading this results in the above MSBuild error.

Here is a minimal repro: https://gist.github.com/Quppa/dae4eacf58d9b23009bcc447b4d9cb93

[jaredpar]

Note this also applies to EmbedAllSources

[Quppa]

Moving my comment from the other thread:

Upon further investigation the issue is that our csproj files were missing this line:
<Import Project="..\packages\Microsoft.Net.Compilers.2.4.0\build\Microsoft.Net.Compilers.props" Condition="Exists('..\packages\Microsoft.Net.Compilers.2.4.0\build\Microsoft.Net.Compilers.props')" />

Microsoft.Net.Compilers.props sets the value of CSharpCoreTargetsPath, which appears to override the <Import Project="$(MSBuildBinPath)\Microsoft.CSharp.targets" /> line.

The above import is included for a new ASP.NET Web Forms project, and I'm not quite sure how we ended up without it. This might have been a casualty of our conversion from packages.config to PackageReference - I thought maybe the csproj modification was happening in install.ps1 (unsupported by PackageReference), but I can't actually see what does it.

Creating a new project produces a csproj with these lines at the top:

  <Import Project="..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.8\build\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props" Condition="Exists('..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.8\build\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props')" />
  <Import Project="..\packages\Microsoft.Net.Compilers.2.4.0\build\Microsoft.Net.Compilers.props" Condition="Exists('..\packages\Microsoft.Net.Compilers.2.4.0\build\Microsoft.Net.Compilers.props')" />

and at the bottom:

  <Target Name="EnsureNuGetPackageBuildImports" BeforeTargets="PrepareForBuild">
    <PropertyGroup>
      <ErrorText>This project references NuGet package(s) that are missing on this computer. Use NuGet Package Restore to download them.  For more information, see http://go.microsoft.com/fwlink/?LinkID=322105. The missing file is {0}.</ErrorText>
    </PropertyGroup>
    <Error Condition="!Exists('..\packages\Microsoft.Net.Compilers.2.4.0\build\Microsoft.Net.Compilers.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.Net.Compilers.2.4.0\build\Microsoft.Net.Compilers.props'))" />
    <Error Condition="!Exists('..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.8\build\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props')" Text="$([System.String]::Format('$(ErrorText)', '..\packages\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.1.0.8\build\net45\Microsoft.CodeDom.Providers.DotNetCompilerPlatform.props'))" />
  </Target>

[Quppa]

The above Imports only work, of course, if the packages are located in ..\packages, but the default these days seems to be in the .nuget directory in the current user's directory.

[Jinhuafei]

@Quppa the issue only happens on package reference mode?

[Quppa]

@Jinhuafei I believe the Imports are added correctly when the package is installed using packages.config, yes.

[Quppa]

Version 2.8.0-beta1-62707-12 of Roslyn seems not to include any new CSC parameters, so the VS15.7 update might be pain-free in this respect.

[Jinhuafei]

The root cause of the problem is the Roslyn compiler shipped with VS is newer than the Roslyn compiler nupkg referenced by the project, and that new version Roslyn adds some new compiler parameters in Microsoft.CSharp.targets. The codedom provider nupkg is going to remove the dependency on Roslyn nupkg which means msbuild will only use the Roslyn compiler shipped with it. So this problem should be mitigated after this change.

[Quppa]

That sounds promising - can you give any indication of when this update will be released?

[Jinhuafei]

It should be in this month. I published a version onto myget for testing purpose. You can give it a try. The final version will be 1.1.0.

Install-Package Microsoft.CodeDom.Providers.DotNetCompilerPlatform -Version 1.0.9 -Source https://www.myget.org/F/roslyncodedomprovider/api/v3/index.json

[Jinhuafei]

BTW, after you install the new version. Please remember to remove Microsoft.Net.Compilers nupkg from your project.

[antonberezan]

@Jinhuafei any update on this? Could you please tell when 1.1.0 will be published to nuget?

[Jinhuafei]

We are targeting to next week.