Use new common benchmark config #1251
Conversation
|
|
||
| namespace Microsoft.AspNetCore.SignalR.Microbenchmarks | ||
| { | ||
| public class CoreConfig : ManualConfig |
There was a problem hiding this comment.
Is this configuration no longer required, or did the logic move somewhere else?
There was a problem hiding this comment.
Moved to common: dotnet/extensions#303
|
Travis failure is due to unrelated flakiness |
| @@ -0,0 +1 @@ | |||
| [assembly: BenchmarkDotNet.Attributes.AspNetCoreBenchmark] | |||
There was a problem hiding this comment.
You don't need to change this...i'm just curious. Would does this work if you put it into the csproj file?
<ItemGroup>
<AssemblyAttribute Include="BenchmarkDotNet.Attributes.AspNetCoreBenchmark" />
</ItemGroup>If so, you could add this piece of MSBuild into the Benchmark.Sources package so it's automatically applied to any benchmark project that uses it.
There was a problem hiding this comment.
I don't want things that implicit. There might be a case where configs need to be overridden and having source file is much easier than trying to find some packages target that brought attribute and figure out how to change it.
There was a problem hiding this comment.
I could've just dropped assembly info into source package too.
No description provided.