Make build.cmd work and do npm pack #45
Conversation
|
This produces a package with a different shape than what's published on NPM (3.2.4), and there's a version (3.2.5) published on nuget which isn't on npm. @kichalla can you shed some light on any of this? The new package shape seems to be more correct (it matches both what jquery does and what jquery.validation.unobtrusive does), so maybe we just fixed it up to meet "standards" then publishing to npm got missed or silently failed? |
build.msbuild
Outdated
| <Target Name="Build"> | ||
| <ReadLinesFromFile File="@(VersionFile)"> | ||
| <Output TaskParameter="Lines" PropertyName="PackageVersion"/> | ||
| </ReadLinesFromFile> | ||
| <Exec Command="npm install" /> | ||
| <Exec Command="npm version --no-git-tag-version --allow-same-version $(PackageVersion)" /> | ||
| <Exec Command="npx gulp" /> | ||
| <Exec Command="nuget pack $(NuspecPath) -Version $(PackageVersion)" /> | ||
| <Exec Command="$(MSBuildThisFileDirectory)node_modules\.bin\gulp" /> |
There was a problem hiding this comment.
The more cross-plat-friendly way to do this is npm run build and then put the call to gulp in the build task in your package.json. This takes care of knowing where to find the gulp executable - you don't have to hardcode the node_modules\.bin\gulp path.
build.msbuild
Outdated
| </PropertyGroup> | ||
|
|
||
| <ItemGroup> | ||
| <DistDirFiles Include="$(DistDir)*.*;"/> |
There was a problem hiding this comment.
I'm curious about the use of $(DistDir)*.*; instead of just $(DistDir)*. Is it possible this could be simplified, or is this glob format needed?
There was a problem hiding this comment.
The implementation looks good. I'd recommend we do make the change to use npm run build but it's not a massive deal if we only expect this to be built on Windows.
I don't have an opinion about the resulting NPM package shape since I don't know what the requirements are.
|
🆙📅'ed with @SteveSandersonMS's suggestion. |
|
Nicely done! |
Some changes to bring building this repo in line with https://github.com/aspnet/jquery-validation-unobtrusive.
I also stopped checking in the dist folder as part of aspnet/Coherence-Signed#953.