-
-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use Yalc to fix version mismatch #1181
Conversation
Awesome!
Agree with that. I tried to centralize the config so that the parcel dev dep is only in the workspace dev dependencies. This works fine. The only thing I didn't manage to get working for some reason is to use Also, I removed the yalc:publish since this will not be necessary, when yalc is called after each build or branch change, or did I oversee something? Will add the git hook later tonight. |
Great, thank you !
Too bad. But from my experience, it's pretty rare I need to watch all frontend packages at the same time. Usually one or two is enough.
The case I could see is on a fresh git clone: you don't need to do the build (packages are already built), but you need the yalc publish. However if this can be automated with the git hooks, it probably won't be needed. |
My bad, that's the scenario that'd be useful to have the script for, I suppose :D |
use nx for build and watch
Thanks, the git hooks are working great ! |
yalc:publish
NPM script on the /src/frontend directory which publish all SemApps packages to Yalc.build
NPM script is called.build
andwatch
NPM scripts on the@semapps/auth-provider
package (according to this issue, nodemon is the only way to trigger a command after parcel build)See this PR on ActivityPods for changes on the other side: activitypods/activitypods#108
What's next ?
yalc:publish
every time the git branch is changed. Apparently this is possible with a git hook. @mguihal @Laurin-W What do you think of this idea ? Would one of you give it a try ? We would need a flexible error handling, in case yalc is not installed.build
andwatch
scripts on all SemApps packages.Remaining issue
yarn link
for middleware packages ? That seems easier since we don't have to bother about watching and publishing.