fix: don't fail with overwrite #188
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
epage
reviewed
Jan 4, 2023
|
I will work on it after #189 is out of the way so I don't get merge conflicts |
|
@figsoda thinking about this more, this is an issue when the user is directly interacting with the program. The current behavior is a bug. What this PR introduces also has bugs. The question is which bug is worse. I think I lean towards the current behavior being worse. What do you think? If we agree the current behavior is worse, we could possibly merge this now, open a new issue, and then work to get that new issue fixed. This would make it so people have the better experience sooner. Thoughts? |
|
I agree, the current behavior basically fails every single time on TRYCMD=overwrite and doesn't give much information as an interactive command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fixes #31