Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double type not mapped to Number #23

Closed
otoniel-isidoro opened this issue Sep 4, 2015 · 4 comments
Closed

Double type not mapped to Number #23

otoniel-isidoro opened this issue Sep 4, 2015 · 4 comments

Comments

@otoniel-isidoro
Copy link

A column was declared as DOUBLE on h2 database and the H2 map it to java.lang.Double but on the ValueType.getType method the java.lang.Double is not mapped to NUMBER.
Then the following assert is not possible because it always get an error:

assertThat(table).hasNumberOfRows(1).column("valor").value(0).isEqualTo(120d);
java.lang.AssertionError: [Value at index 0 of Column at index 2 (column name : VALOR) of contas table] 
Expecting:
  <120.0>
to be of type
  <NUMBER>
but was of type
  <NOT_IDENTIFIED>
@otoniel-isidoro
Copy link
Author

Tests for type double are missing too.

@regis1512
Copy link
Member

Please, give me your test results but for me it is closed

@otoniel-isidoro
Copy link
Author

I apologize for the delay in answering but I am very busy these days. I already got this implementation and it looks ok. Thanks.

@regis1512
Copy link
Member

No problem. You are welcome. It is the same for all of us. We do that when we have time : there are other priorities in the life and it is very well like that.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants