Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[bug]: res_pjsip: Mediasec requires different headers on 401 response #48

Closed
1 task done
maximilianfridrich opened this issue May 2, 2023 · 0 comments · Fixed by #49
Closed
1 task done

[bug]: res_pjsip: Mediasec requires different headers on 401 response #48

maximilianfridrich opened this issue May 2, 2023 · 0 comments · Fixed by #49
Assignees
@maximilianfridrich
Labels
bug support-level-core Functionality with core support level

Comments

@maximilianfridrich
Copy link
Contributor

Severity

Minor

Versions

16.29.0, 18.15.0, 20.0.0

Components/Modules

res_pjsip, res_pjsip_outbound_registration

Operating Environment

Debian 11

Frequency of Occurrence

Constant

Issue Description

The Deutsche Telekom requires certain headers in SIP requests which are based on draft-dawes-sipcore-mediasec-parameter. This draft requires different headers in requests sent after a 401 as compared to 494. Specifically, in requests sent after a 401 response, the Security-Client header must still be present (see section 6.1 in the draft) while in requests after a 494 it should not be present.

The original mediasec implementation didn't consider that.

Relevant log output

No response

Asterisk Issue Guidelines

  • Yes, I have read the Asterisk Issue Guidelines
@maximilianfridrich maximilianfridrich mentioned this issue May 2, 2023
Merged
maximilianfridrich added a commit to maximilianfridrich/asterisk that referenced this issue May 2, 2023
@maximilianfridrich
res_pjsip: mediasec: Add Security-Client headers after 401
91df79a 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: asterisk#48
@jcolp jcolp added support-level-core Functionality with core support level and removed triage labels May 2, 2023
maximilianfridrich added a commit to maximilianfridrich/asterisk that referenced this issue May 2, 2023
@maximilianfridrich
res_pjsip: mediasec: Add Security-Client headers after 401
3ee0452 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: asterisk#48
maximilianfridrich added a commit to maximilianfridrich/asterisk that referenced this issue May 2, 2023
@maximilianfridrich
res_pjsip: mediasec: Add Security-Client headers after 401
0d0c732 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: asterisk#48
gtjoseph pushed a commit that referenced this issue May 2, 2023
@maximilianfridrich
res_pjsip: mediasec: Add Security-Client headers after 401 (#49)
cacd98b 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: #48
asteriskteam pushed a commit that referenced this issue May 2, 2023
@maximilianfridrich
res_pjsip: mediasec: Add Security-Client headers after 401
f3cc1e7 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: #48
asteriskteam pushed a commit that referenced this issue May 2, 2023
@maximilianfridrich
res_pjsip: mediasec: Add Security-Client headers after 401
ecd5f91 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: #48
asterisk-org-access-app bot pushed a commit that referenced this issue May 8, 2023
@maximilianfridrich @asteriskteam
res_pjsip: mediasec: Add Security-Client headers after 401
7ad10c9 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: #48
(cherry picked from commit ecd5f91)
asterisk-org-access-app bot pushed a commit that referenced this issue May 8, 2023
@maximilianfridrich @asteriskteam
res_pjsip: mediasec: Add Security-Client headers after 401
7140faf 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: #48
(cherry picked from commit ecd5f91)
asterisk-org-access-app bot pushed a commit that referenced this issue May 8, 2023
@maximilianfridrich @asteriskteam
res_pjsip: mediasec: Add Security-Client headers after 401
9cfda39 
When using mediasec, requests sent after a 401 must still contain the
Security-Client header according to
draft-dawes-sipcore-mediasec-parameter.

Resolves: #48
(cherry picked from commit f3cc1e7)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@maximilianfridrich maximilianfridrich

Labels
bug support-level-core Functionality with core support level
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

res_pjsip: mediasec: Add Security-Client headers after 401 maximilianfridrich/asterisk
2 participants
@jcolp @maximilianfridrich