This repository was archived by the owner on Jul 27, 2023. It is now read-only.
tuple constants are for optimisations, not source #28
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
my reading of https://docs.python.org/3/library/ast.html#ast.unparse and https://discuss.python.org/t/ast-constant-value-tuple-s-and-frozenset-s/22578 is that tuple constants cannot come from parsing python source, they are only for optimised bytecode see also astral-sh/ruff#5812
|
thanks. how do i get a new release tagged? |
|
If you want to open a PR in Ruff to upgrade to |
|
(We just use the SHA in |
|
Or @zanieb may end up doing the upgrade now anyway. |
|
ah, i misunderstood the comment in |
davidszotten
added a commit
to davidszotten/ruff
that referenced
this pull request
Jul 17, 2023
zanieb
added a commit
to astral-sh/ruff
that referenced
this pull request
Jul 17, 2023
zanieb
added a commit
to astral-sh/ruff
that referenced
this pull request
Jul 17, 2023
c.f. astral-sh/RustPython-Parser#28 Tests: No snapshots changed --------- Co-authored-by: Zanie <contact@zanie.dev>
evanrittenhouse
pushed a commit
to evanrittenhouse/ruff
that referenced
this pull request
Jul 19, 2023
c.f. astral-sh/RustPython-Parser#28 Tests: No snapshots changed --------- Co-authored-by: Zanie <contact@zanie.dev>
konstin
pushed a commit
to astral-sh/ruff
that referenced
this pull request
Jul 19, 2023
c.f. astral-sh/RustPython-Parser#28 Tests: No snapshots changed --------- Co-authored-by: Zanie <contact@zanie.dev>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
my reading of https://docs.python.org/3/library/ast.html#ast.unparse and https://discuss.python.org/t/ast-constant-value-tuple-s-and-frozenset-s/22578 is that tuple constants cannot come from parsing python source, they are only for optimised bytecode
see also astral-sh/ruff#5812