windows: Sync SQLite build flags from the UNIX build #800
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
geofft
added
platform:windows
zanieb
approved these changes
Sep 18, 2025
zanieb
reviewed
Sep 18, 2025
Comment on lines
+573
to
+579
| b"SQLITE_ENABLE_DBSTAT_VTAB", | ||
| b"SQLITE_ENABLE_FTS3", | ||
| b"SQLITE_ENABLE_FTS3_PARENTHESIS", | ||
| b"SQLITE_ENABLE_FTS4", | ||
| b"SQLITE_ENABLE_FTS5", | ||
| b"SQLITE_ENABLE_GEOPOLY", | ||
| b"SQLITE_ENABLE_RTREE", |
There was a problem hiding this comment.
It sounds like this list should live somewhere else!
There was a problem hiding this comment.
Yeah, I sort of thought it was in code somewhere already, but it's currently inline in the shell script on the UNIX side. We should maybe do something like extension-modules.yml for our native builds.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Notably this adds
-DENABLE_FTS3_PARENTHESIS#550)