Repository navigation
Replies: 1 comment
|
Feel free to open a PR, but please be sure to abide by our AI Policy. Your comment was likely flagged because it read as LLM-authored. |
0 replies
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Uh oh!
There was an error while loading. Please reload this page.
Hi everyone!
I'm a student at the University of Michigan currently working on an open-source contribution as part of my software engineering course. I chose Ruff because I was interested in learning more about static analysis and contributing to an established open-source project.
I've been working on Issue #30225, which involves B012 failing to detect certain control-flow statements inside nested branches of
finallyblocks.I was able to reproduce both reported failures and implemented a local fix that extends AST traversal to cover missing
elif,else, andexceptbranches along with additional edge cases. I've also added regression tests and all 2,830 active linter tests passed locally.My changes are committed and available on my fork:
https://github.com/cheeto734/ruff/tree/fix-b012-finally-branches
I previously tried commenting on the original issue to ask whether the maintainers would welcome a pull request but my comments were automatically hidden as spam or low-quality content :(. I also attempted to access the Ruff Discord but wasn't able to join so I'm reaching out here instead.
Would it be appropriate for me to open a pull request for this fix? I'd also appreciate any feedback on the implementation or guidance on the best way to proceed.
Thank you for your time!
All reactions