[perflint] Expand PERF401 and PERF402 with type checks

[qdegraaf]

Summary

Attempt at a small improvement to two perflint rules using the new type inference capabilities to only flag PERF401 and PERF402 for values we infer to be lists. This makes the rule more conservative, as it only flags values that we know to be lists, but it's overall a desirable change, as it favors false negatives over false positives for a "nice-to-have" rule.

Closes #6995.

Test Plan

Add non-list value cases and make sure all old cases are still caught.

[charliermarsh]

I think the id variable is just being overridden unintentionally. I'll push an update.

[charliermarsh]

I think this is a desirable change. These rules are nice-to-haves and so I'd really like to avoid false negatives.

[charliermarsh]

I wonder why the ecosystem check isn't running on this PR.

[charliermarsh]

Oh, it's running now -- nevermind.

[github-actions]

PR Check Results

Ecosystem

ℹ️ ecosystem check detected changes. (+0, -19, 0 error(s))

airflow (+0, -16)

- airflow/cli/commands/standalone_command.py:300:13: PERF401 Use a list comprehension to create a transformed list
- airflow/decorators/base.py:241:17: PERF401 Use a list comprehension to create a transformed list
- airflow/decorators/base.py:260:21: PERF401 Use a list comprehension to create a transformed list
- airflow/jobs/triggerer_job_runner.py:691:13: PERF402 Use `list` or `list.copy` to create a copy of a list
- airflow/kubernetes/pre_7_4_0_compatibility/pod_generator_deprecated.py:180:13: PERF401 Use a list comprehension to create a transformed list
- airflow/kubernetes/pre_7_4_0_compatibility/pod_generator_deprecated.py:213:17: PERF401 Use a list comprehension to create a transformed list
- airflow/providers/cncf/kubernetes/pod_generator_deprecated.py:181:13: PERF401 Use a list comprehension to create a transformed list
- airflow/providers/cncf/kubernetes/pod_generator_deprecated.py:214:17: PERF401 Use a list comprehension to create a transformed list
- airflow/www/extensions/init_appbuilder.py:658:25: PERF401 Use a list comprehension to create a transformed list
- docs/conf.py:263:13: PERF401 Use a list comprehension to create a transformed list
- docs/conf.py:267:13: PERF401 Use a list comprehension to create a transformed list
- tests/providers/amazon/aws/transfers/test_dynamodb_to_s3.py:57:17: PERF401 Use a list comprehension to create a transformed list
- tests/providers/cncf/kubernetes/utils/test_pod_manager.py:500:13: PERF401 Use a list comprehension to create a transformed list
- tests/providers/cncf/kubernetes/utils/test_pod_manager.py:502:13: PERF401 Use a list comprehension to create a transformed list
- tests/providers/cncf/kubernetes/utils/test_pod_manager.py:735:13: PERF401 Use a list comprehension to create a transformed list
- tests/providers/cncf/kubernetes/utils/test_pod_manager.py:737:13: PERF401 Use a list comprehension to create a transformed list

bokeh (+0, -3)

- src/bokeh/layouts.py:486:25: PERF401 Use a list comprehension to create a transformed list
- src/bokeh/sphinxext/bokeh_plot.py:272:21: PERF401 Use a list comprehension to create a transformed list
- tests/unit/bokeh/protocol/messages/test_patch_doc.py:103:13: PERF401 Use a list comprehension to create a transformed list

Rules changed: 2

Rule	Changes	Additions	Removals
PERF401	18	0	18
PERF402	1	0	1