Skip to content

Allow xmp_packet_index to be passed to from_image to select XMP packet to use #24

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Jul 29, 2017
Merged

Allow xmp_packet_index to be passed to from_image to select XMP packet to use #24

merged 6 commits into from
Jul 29, 2017

Conversation

astrofrog
Copy link
Owner

@astrofrog astrofrog commented Mar 25, 2014 •
edited
Loading

To-do:

  • emit warning if no value is passed and multiple XMP packets are present.
  • give nice error if index is too large

@keflavich
Copy link
Contributor

I'm working off of this branch; might be good to merge?

@keflavich
Copy link
Contributor

@astrofrog - this is needed for aplpy/aplpy#330 (comment), can it be merged?

@astrofrog astrofrog force-pushed the multiple-xmp-packets branch from 4203646 to 188f740 Compare July 29, 2017 22:46
@astrofrog astrofrog force-pushed the multiple-xmp-packets branch from 188f740 to 9ee4db4 Compare July 29, 2017 22:47
@astrofrog astrofrog merged commit 1854155 into master Jul 29, 2017
@astrofrog
Copy link
Owner Author

@keflavich - sorry it took so long to wrap this up!

@astrofrog astrofrog mentioned this pull request Jul 29, 2017
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@astrofrog @keflavich