-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: scikit-base
registry and testing framework
#26
Conversation
What's the rationale behind changing the location for the tests folder? |
technically, I've added it, not changed it. I just did not know for certain where to put it. No strong opinions where it should go. |
2nd one is resolved, the issue was:
This is solved by:
|
I've investigated the first issue, and the failure is not, as I thought, about generators or not. The problem is that if
Reproducing code: from tsbootstrap.block_bootstrap import BlackmanBootstrap
from tsbootstrap.tests.scenarios.scenarios_bootstrap import BootstrapUnivarRetIx
boot = BlackmanBootstrap()
sc = BootstrapUnivarRetIx()
# this is the same as running the blackman bootstrap
# with some X, y, and return_indices=True
result_gen = sc.run(boot, method_sequence=["bootstrap"])
result_list = list(result_gen) # then investigate this list |
Codecov ReportAttention: Patch coverage is
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #26 +/- ##
==========================================
+ Coverage 84.77% 88.59% +3.82%
==========================================
Files 17 31 +14
Lines 2607 2763 +156
==========================================
+ Hits 2210 2448 +238
+ Misses 397 315 -82 ☔ View full report in Codecov by Sentry. |
Depends on #10 which should be merged first. Implements #9
Adds
scikit-base
machinery, forsktime
compatibility.Contents:
all_objects
, including testsBaseObject
interface contract test class,TestAllObjects
TestAllBootstraps
a test class specific to bootstrap objects, currently testing input/output contract of thebootstrap
methodcapability:multivariate
, which distinguishes boostrap algorithms that can vs cannot handle multivariate data. Used in an informative user facing error message, and matching algorithms with test scenarios.One open question is, where should tests live?
I added tests currently in a sub-folder of
tsbootstrap
rather than the currenttests
folder, but that's not necessary.