Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: isolate arch and statsmodels as soft dependencies, new all_extras soft dependency set #39

Merged
merged 24 commits into from
Feb 3, 2024

Conversation

fkiraly
Copy link
Collaborator

@fkiraly fkiraly commented Jan 19, 2024

This PR isolates arch and statsmodels as soft dependencies, moving them to an all_extras soft dependency set.

Isolation is done as follows:

  • moving imports into functions and classes
  • adding a _tags variable with dependencies specified to all classes impacted
  • isolating tests with pytest.skipif using skbase _check_soft_dependencies
  • skipping doctests triggering the imports. Important, if this reduces coverage, we should add those doctests as pytests.
  • removing or replacing type annotations that require imports

Includes changes:

  • the CI test.yml is updated to include a full test run with all soft dependencies, and one without. The former is functionally identical with current, the latter is a new job called test-no-softdeps.
  • the CI test.yml is updated with a job testing for full dependency isolation, test-nodevdeps, using skbase all_objects to test successful import of all modules except tests
  • minor change, adds a few test skips missed in fix: temporarily skip sporadically failing tests due to LU decomposition #28

I would recommend to merge #10 and #26 first to ensure better test coverage before merging this.

Depends on #40 so CI runs, that PR should be merged first.

@fkiraly fkiraly added the dependencies Pull requests that update a dependency file label Jan 19, 2024
@fkiraly fkiraly changed the title feat: isolate arch and statsmodels as soft dependencies feat: isolate arch and statsmodels as soft dependencies, new all_extras soft dependency set Jan 19, 2024
@fkiraly
Copy link
Collaborator Author

fkiraly commented Feb 3, 2024

approved via #52

@fkiraly fkiraly merged commit d2ef065 into astrogilda:main Feb 3, 2024
11 checks passed
fkiraly added a commit that referenced this pull request Feb 3, 2024
This PR isolates `scikit-learn-extra` as soft dependencies, moving them
to an `all_extras` soft dependency set.

There is only one import, which is moved together with its use, in
`BlockCompressor`.

Depends on #39 for the
updated CI and soft dependency isolation test.
@fkiraly fkiraly mentioned this pull request Feb 4, 2024
@fkiraly fkiraly linked an issue Feb 4, 2024 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

dependencies consolidation
2 participants