-
-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: isolate arch
and statsmodels
as soft dependencies, new all_extras
soft dependency set
#39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fkiraly
changed the title
feat: isolate
feat: isolate Jan 19, 2024
arch
and statsmodels
as soft dependenciesarch
and statsmodels
as soft dependencies, new all_extras
soft dependency set
approved via #52 |
fkiraly
added a commit
that referenced
this pull request
Feb 3, 2024
This PR isolates `scikit-learn-extra` as soft dependencies, moving them to an `all_extras` soft dependency set. There is only one import, which is moved together with its use, in `BlockCompressor`. Depends on #39 for the updated CI and soft dependency isolation test.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR isolates
arch
andstatsmodels
as soft dependencies, moving them to anall_extras
soft dependency set.Isolation is done as follows:
_tags
variable with dependencies specified to all classes impactedpytest.skipif
usingskbase
_check_soft_dependencies
Includes changes:
test.yml
is updated to include a full test run with all soft dependencies, and one without. The former is functionally identical with current, the latter is a new job calledtest-no-softdeps
.test.yml
is updated with a job testing for full dependency isolation,test-nodevdeps
, usingskbase
all_objects
to test successful import of all modules excepttests
I would recommend to merge #10 and #26 first to ensure better test coverage before merging this.
Depends on #40 so CI runs, that PR should be merged first.