fix: temporarily skip sporadically failing tests due to LU decomposition #28
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@astrogilda, should we not just skip all failing tests until resolved, and open an issue to track the problem? |
fkiraly
changed the title
test_get_residuals_valid_sarima until LU decomposition issue is fixed
Closed
fkiraly
added a commit
that referenced
this pull request
Feb 3, 2024
…_extras` soft dependency set (#39) This PR isolates `arch` and `statsmodels` as soft dependencies, moving them to an `all_extras` soft dependency set. Isolation is done as follows: * moving imports into functions and classes * adding a `_tags` variable with dependencies specified to all classes impacted * isolating tests with `pytest.skipif` using `skbase` `_check_soft_dependencies` * skipping doctests triggering the imports. Important, if this reduces coverage, we should add those doctests as pytests. * removing or replacing type annotations that require imports Includes changes: * the CI `test.yml` is updated to include a full test run with all soft dependencies, and one without. The former is functionally identical with current, the latter is a new job called `test-no-softdeps`. * the CI `test.yml` is updated with a job testing for full dependency isolation, `test-nodevdeps`, using `skbase` `all_objects` to test successful import of all modules except `tests` * minor change, adds a few test skips missed in #28
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a temporary fix for sporadic failures of tests in
TestTSFitrelated toTSFitcalls with the"arima"and"sarima"model strategies.This is intended as temporary measure, until LU decomposition issues are fixed. Tracking issue is #41.