Add the ability to change the deployment type to dag_deploy from the CLI (both for create and update) #1516
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1516 +/- ##
=======================================
Coverage 85.92% 85.93%
=======================================
Files 112 112
Lines 14838 14843 +5
=======================================
+ Hits 12750 12755 +5
Misses 1252 1252
Partials 836 836 ☔ View full report in Codecov by Sentry. |
rujhan-arora-astronomer
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
rujhan-arora-astronomer
requested review from
danielhoherd,
rishkarajgi and
pgvishnuram
neel-astro
approved these changes
Feb 1, 2024
kushalmalani
reviewed
Feb 1, 2024
This is needed to support Go 1.21 - Depguard changed to v2 so the default mod changed - Revive was just noisey, so has been removed - I removed some repeated (sub)strings into consts - I also moved a repeated code block (detected by contsnts) into a function
Also switch from using deprecated CircleCI images in favour of the new ones
…c, dag_only for all cases
kushalmalani
approved these changes
Feb 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Add the ability to change the deployment type to dag_deploy from the CLI (both for create and update)
🎟 Issue(s)
Related issue
https://github.com/astronomer/issues/issues/6119
🧪 Functional Testing
Locally
📸 Screenshots
📋 Checklist
make testbefore taking out of draftmake lintbefore taking out of draft