Update version of golangci-lint to the latest version #1522
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashb
requested review from
neel-astro,
kushalmalani,
sunkickr and
vandyliu
as code owners
ashb
commented
Feb 1, 2024
cloud/deployment/deployment.go
Outdated
Comment on lines
515
to
542
| func deploymentToTableRow(table *printutil.Table, d *astroplatformcore.Deployment, includeWorkspaceName bool) { | ||
| var clusterName, region string | ||
| runtimeVersionText := d.RuntimeVersion + " (based on Airflow " + d.AirflowVersion + ")" | ||
| cloudProvider := notApplicable | ||
| releaseName := d.Namespace | ||
| if IsDeploymentStandard(*d.Type) { | ||
| cloudProvider = *d.CloudProvider | ||
| region = *d.Region | ||
| } else { | ||
| clusterName = *d.ClusterName | ||
| } | ||
| cols := []string{ | ||
| d.Name, | ||
| releaseName, | ||
| clusterName, | ||
| cloudProvider, | ||
| region, | ||
| d.Id, | ||
| runtimeVersionText, | ||
| strconv.FormatBool(d.IsDagDeployEnabled), | ||
| strconv.FormatBool(d.IsCicdEnforced), | ||
| string(*d.Type), | ||
| } | ||
| if includeWorkspaceName { | ||
| cols = slices.Insert(cols, 1, *d.WorkspaceName) | ||
| } | ||
| table.AddRow(cols, false) |
There was a problem hiding this comment.
I'd like a second pair of eyes on this change specifically.
ashb
force-pushed
the
upgrade-golanglint
branch
from
4f2e262
to
2ae68d7
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #1522 +/- ##
==========================================
+ Coverage 85.90% 85.92% +0.01%
==========================================
Files 112 112
Lines 14847 14838 -9
==========================================
- Hits 12755 12750 -5
+ Misses 1254 1252 -2
+ Partials 838 836 -2 ☔ View full report in Codecov by Sentry. |
neel-astro
approved these changes
Feb 1, 2024
This is needed to support Go 1.21 - Depguard changed to v2 so the default mod changed - Revive was just noisey, so has been removed - I removed some repeated (sub)strings into consts - I also moved a repeated code block (detected by contsnts) into a function
ashb
force-pushed
the
upgrade-golanglint
branch
from
2ae68d7
to
63a9903
Compare
rujhan-arora-astronomer
pushed a commit
that referenced
this pull request
Feb 2, 2024
This is needed to support Go 1.21 - Depguard changed to v2 so the default mod changed - Revive was just noisey, so has been removed - I removed some repeated (sub)strings into consts - I also moved a repeated code block (detected by contsnts) into a function
kushalmalani
pushed a commit
that referenced
this pull request
Feb 2, 2024
…CLI (both for create and update) (#1516) * Add the ability to change the deployment type to dag_deploy from the CLI * Update version of golangci-lint to the latest version (#1522) This is needed to support Go 1.21 - Depguard changed to v2 so the default mod changed - Revive was just noisey, so has been removed - I removed some repeated (sub)strings into consts - I also moved a repeated code block (detected by contsnts) into a function * Update to latest Go versions (#1521) Also switch from using deprecated CircleCI images in favour of the new ones * Streamline getDeploymentTypeCmdMessage to show image, volume, git_sync, dag_only for all cases * change function call to constant --------- Co-authored-by: Ash Berlin-Taylor <ash_github@firemirror.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to support Go 1.21